Project

General

Profile

Bug #249

BeemService please assert this error

Added by John Pope almost 9 years ago. Updated almost 9 years ago.

Status:
Closed
Priority:
Low
Assignee:
Category:
XMPP
Target version:
Start date:
02/26/2010
Due date:
% Done:

100%

Estimated time:
Affected version:
hg
Locale:
Close

Description

line 194

mLogin = StringUtils.parseName(tmpJid);
when connecting to a local openfire server with USERNAME=admin PASSWORD=admin (with no @domain.com), the ignite StringUtil parser returns null.

if (mLogin  "") {
Log.e(TAG, "Error parsing username / is it a valid JID??");
if (tmpJid ""){
Log.e(TAG, "User Input Error - no username configured");
// return; throw error
}else{
mLogin =tmpJid;
}
}

Associated revisions

Revision 712:bbd54153f92c (diff)
Added by Nikita Kozlov almost 9 years ago

Bug #249 and a small debug on AccountConfigure.java

Revision 712:bbd54153f92c (diff)
Added by Nikita Kozlov almost 9 years ago

Bug #249 and a small debug on AccountConfigure.java

Revision 712:bbd54153f92c (diff)
Added by Nikita Kozlov almost 9 years ago

Bug #249 and a small debug on AccountConfigure.java

History

#1 Updated by Jean-Manuel Da Silva almost 9 years ago

According to the trunk, this one has been fixed.

    String tmpJid = mSettings.getString("settings_key_account_username", "");
    mLogin = StringUtils.parseName(tmpJid);
    mPassword = mSettings.getString("settings_key_account_password", "");
    mPort = DEFAULT_XMPP_PORT;
    mService = StringUtils.parseServer(tmpJid);
    mHost = StringUtils.parseServer(tmpJid);

    if (mSettings.getBoolean("settings_key_specific_server", false)) {
        mHost = mSettings.getString("settings_key_xmpp_server", "");
        if ("".equals(mHost))
        mHost = StringUtils.parseServer(tmpJid);
        String tmpPort = mSettings.getString("settings_key_xmpp_port", "5222");
        mPort = ("".equals(tmpPort)) ? DEFAULT_XMPP_PORT : Integer.parseInt(tmpPort);
    }
    if ("gmail.com".equals(mService) || "googlemail.com".equals(mService))  {
        mLogin = tmpJid;
    }

#2 Updated by Jean-Manuel Da Silva almost 9 years ago

  • Status changed from New to Feedback

#3 Updated by Nikita Kozlov almost 9 years ago

  • Status changed from Feedback to Resolved
  • Assignee set to Nikita Kozlov
  • Target version set to 0.1.3
  • % Done changed from 0 to 100

resolved in r712

#4 Updated by Frédéric Barthéléry almost 9 years ago

  • Status changed from Resolved to Closed

You must use a full JID. Your JID for the admin of openfire is admin@localhost (or your IP address). Some checks was added to see if the domain is valid.

Also available in: Atom PDF