Project

General

Profile

Pull request #480

code cleanup

Added by J Pinkava almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Low
Category:
-
Target version:
Start date:
01/20/2013
Due date:
% Done:

100%

Estimated time:
Repository:
https://bitbucket.org/pinky/beem
Close

Description

Only minor changes or cleanups

- update to latest SmileyParser
- replace deprecated onStart() with onStartCommand()
- remove some unused variables
- close some streams (silence some warnings)
- fix spelling of Remko Tronçon name (com/isode/stroke/*)

https://pinky@bitbucket.org/pinky/beem

History

#1 Updated by J Pinkava almost 6 years ago

Sinc I'm new to mercurial and pull requests, please let me now hot to improve me pull requests.

commits related to previously mentioned work are:
9240220d08b3
7c12f92792ae
becbb0b21aee
3437a00c5a35

I'm continously pushing new commits to this branch, all should be in "ready to use" state, but the intent is not squash all to this pull request.

#2 Updated by J Pinkava almost 6 years ago

Approved changes are availlable under bookmark cleanups (3f11cd9)

#3 Updated by J Pinkava almost 6 years ago

Update version of pull request is under bookmark cleanups2 (a8127b6c243e).

#4 Updated by Frédéric Barthéléry almost 6 years ago

  • Status changed from New to Resolved
  • Assignee set to Frédéric Barthéléry
  • Target version set to Dev
  • % Done changed from 0 to 100

Merged in d8ef6a82d715

#5 Updated by Frédéric Barthéléry almost 6 years ago

  • Repository set to https://pinky@bitbucket.org/pinky/beem

#6 Updated by Nikita Kozlov almost 6 years ago

  • Repository changed from https://pinky@bitbucket.org/pinky/beem to https://bitbucket.org/pinky/beem

#7 Updated by Frédéric Barthéléry almost 6 years ago

  • Status changed from Resolved to Closed

#8 Updated by Frédéric Barthéléry almost 6 years ago

  • Target version changed from Dev to 0.1.8

Also available in: Atom PDF